Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] [type] Fix wrong type cast in codegen of storing quant floats #5818

Merged
merged 1 commit into from
Aug 18, 2022

Conversation

strongoier
Copy link
Contributor

Related issue = #4857, fix #5817

@netlify
Copy link

netlify bot commented Aug 18, 2022

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit 088bff7
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/62fddea34690be00099d3479
😎 Deploy Preview https://deploy-preview-5818--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@strongoier strongoier added this to the v1.1.1 milestone Aug 18, 2022
Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@strongoier strongoier merged commit f4305e7 into taichi-dev:master Aug 18, 2022
ailzhang added a commit that referenced this pull request Aug 18, 2022
* [bug] Fix incorrect autodiff_mode information in offline cache key (#5737)

* [bug] Fix incorrect autodiff_mode infomation in offline cache key

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* [Error] Do not show warning when the offline cache path does not exist (#5747)

* [Error] Do not show warning when the offline cache path does not exist

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* [Bug] [type] Fix wrong type cast in codegen of storing quant floats (#5818)

* [autodiff] Support shift ptr in dynamic index (#5770)

* [autodiff] Support shift ptr in dynamic index

* update the offset

* update offset

* add dynamic index test for ad

* forcely enable dynamic index for polar decompose

Co-authored-by: Mingming Zhang <pgzxb@qq.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Lin Jiang <linjiang@taichi.graphics>
Co-authored-by: Yi Xu <xy_xuyi@foxmail.com>
Co-authored-by: Mingrui Zhang <33411325+erizmr@users.noreply.github.com>
@strongoier strongoier deleted the fix-quant-float-under-64 branch August 19, 2022 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Codegen of storing quant floats fails when physical type has 64 bits
2 participants