OpenGL range_for support (stage 2.1.1) #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
range for and extptr (TODO: extptr not work) [skip ci] remove ext ptr fake support Conflicts: examples/opengl_backend.py taichi/codegen/codegen_opengl.cpp taichi/platform/opengl/opengl_kernel.cpp taichi/platform/opengl/opengl_kernel.h Conflicts: taichi/program/program.cpp
Conflicts: taichi/codegen/codegen_opengl.cpp Conflicts: taichi/codegen/codegen_opengl.cpp
Conflicts: taichi/codegen/codegen_opengl.cpp taichi/platform/opengl/opengl_api.cpp taichi/platform/opengl/opengl_api.h taichi/platform/opengl/opengl_data_types.h fix merge Conflicts: taichi/codegen/codegen_opengl.cpp
This was referenced Mar 14, 2020
|
(I'll just say yes to everything related to #545, and squash & merge them, since I've reviewed the final version. When creating small PRs, please make sure every final commit builds in environments without OpenGL to make the buildbots happy. Are you OK with this strategy of mine? If so I'll go ahead and merge the small OpenGL PR pieces. Thanks!) |
|
Ok! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue id = #492