-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[llvm] [refactor] Link modules instead of cloning modules #5962
Merged
+220
−189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsite-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
lin-hitonami
requested review from
jim19930609,
ailzhang,
k-ye and
strongoier
September 5, 2022 03:56
for more information, see https://pre-commit.ci
ailzhang
approved these changes
Sep 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!!!
Only had a fews nits inline.
Btw good to test if building with TI_WITH_LLVM=OFF
still works after this PR locally before merging :P
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue = #5511
The PR seems a bit messy but I can't split it to smaller PRs because these changes must be done together to make the program run.
This PR roughly does things as follows:
link_context_data
and functionlink_compile_data
inTaichiLLVMContext
for linking.struct_module
withstruct_modules
inThreadLocalData
. Thestruct_modules
is a map that stores struct modules of every SNodeTree (The ID of the SNodeTree is the key of the map).get_runtime_function
andget_struct_function
return a function declaration rather than the function definition.compile_kernel_to_module
returns a vector with only one element now. The kernel cache contains only one module now, so it doesn't need to be stored in a vector anymore. I will refactor them later.