-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[aot] C-API texture support and tests #5994
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PENGUINLIONG
force-pushed
the
capi-texture2
branch
3 times, most recently
from
September 7, 2022 03:34
213f341
to
232cb76
Compare
Rename C-API texture to image Support samplers Texture tests [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Revert allocation slices to handles Fix compilation Fixed compilation Fixed test Fixed implementation Fixed test Prevent release of temporary texture allocations [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Fixed unity language binding [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Fixed compilation [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci
PENGUINLIONG
force-pushed
the
capi-texture2
branch
from
September 7, 2022 07:39
232cb76
to
424fa06
Compare
✅ Deploy Preview for docsite-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
for more information, see https://pre-commit.ci
…into capi-texture2
for more information, see https://pre-commit.ci
ailzhang
approved these changes
Sep 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
PENGUINLIONG
added a commit
that referenced
this pull request
Sep 13, 2022
Follow up of #5994. Clang follows a strict separation between C++ headers so fundamental utilities like `std::exchange` is not implicitly included in other `std` headers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improved existing texture interfaces and added related tests. Sampler interfaces are reserved.