Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lang] MatrixNdarray refactor part6: Add scalarization for LocalLoadStmt & GlobalLoadStmt with TensorType #6024

Merged
merged 61 commits into from
Sep 16, 2022

Conversation

jim19930609
Copy link
Contributor

Related issue = #5873, #5819

This PR is working "Part ④" in #5873.

…uction in Ndarray and refactored the use of element_shape
@netlify
Copy link

netlify bot commented Sep 9, 2022

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit 5b0bbfe
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/63241eb60a7e3c0008a7e713
😎 Deploy Preview https://deploy-preview-6024--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@jim19930609 jim19930609 requested review from strongoier, ailzhang and AD1024 and removed request for strongoier September 10, 2022 04:22
@AD1024
Copy link
Contributor

AD1024 commented Sep 12, 2022

Nice work!
Could we have the test cases for defining local matrices when both real_matrix and real_matrix_scalarize=True (just need to make sure these two works together when constructing programs from Python side)

Copy link
Contributor

@strongoier strongoier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

python/taichi/lang/impl.py Outdated Show resolved Hide resolved
taichi/ir/frontend_ir.cpp Outdated Show resolved Hide resolved
taichi/transforms/compile_to_offloads.cpp Outdated Show resolved Hide resolved
taichi/transforms/scalarize.cpp Outdated Show resolved Hide resolved
@jim19930609 jim19930609 merged commit e23ad2d into taichi-dev:master Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants