-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lang] MatrixNdarray refactor part7: Add scalarization for UnaryOpStmt with TensorType-operand #6080
Merged
jim19930609
merged 71 commits into
taichi-dev:master
from
jim19930609:matrix_ndarray_pr8
Sep 21, 2022
Merged
[Lang] MatrixNdarray refactor part7: Add scalarization for UnaryOpStmt with TensorType-operand #6080
jim19930609
merged 71 commits into
taichi-dev:master
from
jim19930609:matrix_ndarray_pr8
Sep 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uction in Ndarray and refactored the use of element_shape
…t to use TensorType
…to matrix_ndarray_pr2
…to matrix_ndarray_pr2
…on-scope AnyArray
…to matrix_ndarray_pr3
…to matrix_ndarray_pr3
…to matrix_ndarray_pr3
…to matrix_ndarray_pr4
…ray at Frontend IR level
…to matrix_ndarray_pr4
…el for dual-indexed MatrixNdarray
…to matrix_ndarray_pr7
…to matrix_ndarray_pr7
…t with TensorTyped operand
…to matrix_ndarray_pr8
✅ Deploy Preview for docsite-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
strongoier
reviewed
Sep 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should UnaryOpStmt
in type_check.cpp
also be modified?
strongoier
approved these changes
Sep 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue = #5873, #5819
This PR is working "Part ④" in #5873.