Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lang] MatrixNdarray refactor part8: Add scalarization for BinaryOpStmt with TensorType-operands #6086

Merged
merged 8 commits into from
Sep 26, 2022

Conversation

jim19930609
Copy link
Contributor

Related issue = #5873, #5819

This PR is working "Part ④" in #5873.

@netlify
Copy link

netlify bot commented Sep 17, 2022

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit 0432ff8
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/633158676b846f0009d4549f
😎 Deploy Preview https://deploy-preview-6086--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@jim19930609
Copy link
Contributor Author

Let @AD1024's PR #6077 go first

@AD1024
Copy link
Contributor

AD1024 commented Sep 25, 2022

Let @AD1024's PR #6077 go first

Merged! Thanks!

python/taichi/lang/matrix.py Outdated Show resolved Hide resolved
taichi/transforms/scalarize.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@strongoier strongoier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jim19930609 jim19930609 merged commit 05e037d into taichi-dev:master Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants