[aot] Import MoltenVK #6090
Merged
[aot] Import MoltenVK #6090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsite-preview canceled.
|
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current implementation, Vulkan instance created by an external MoltenVK cannot be imported via C-API because Taichi would attempt to load
libMoltenVK.dylibby itself and it leads to a crash if the external MoltenVK is linked to the application. This PR introduce a new (optional) interop entry ofvkGetInstanceProcAddrso that externally loaded vulkan library can be reused.This could be an extension to the discussion in #6083 . Statically linking to MoltenVK is potentially saving us from all these hazards.