[gui] Support for setting the initial position of GGUI window #6156
Conversation
This reverts commit b443eb0.
✅ Deploy Preview for docsite-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
for more information, see https://pre-commit.ci
Morcki
requested review from
ailzhang,
YuCrazing,
jim19930609 and
PENGUINLIONG
python/taichi/ui/window.py
Outdated
| @@ -26,14 +26,14 @@ class Window: | |||
| vsync (bool): whether or not vertical sync should be enabled. | |||
| show_window (bool): where or not display the window after initialization. | |||
| """ | |||
| def __init__(self, name, res, vsync=False, show_window=True): | |||
| def __init__(self, name, res, pos=(0, 0), vsync=False, show_window=True): | |||
There was a problem hiding this comment.
pos=(0,0) might be a problem for Windows users who put the task bar on top. Consider (100, 100) or something like that.
There was a problem hiding this comment.
Let me try try on Windows.
There was a problem hiding this comment.
You are right, I will fix that.
There was a problem hiding this comment.
If you need to add a kwarg, it'd be better to add it at the end to avoid breaking current api. e.g. if user had Window('test', (512, 512), False, True) it'll be broken by this PR.
Also pos need a proper docstring explaining which window, and where is the origin ;)
| @@ -90,6 +92,12 @@ inline GLFWwindow *create_glfw_window_(const std::string &name, | |||
| printf("GLFW reports no Vulkan support\n"); | |||
| } | |||
|
|
|||
| // Reset the window hints to default | |||
| glfwDefaultWindowHints(); | |||
There was a problem hiding this comment.
It seems that the Window we create should be invisible before we set the position.
python/taichi/ui/window.py
Outdated
| @@ -26,14 +26,14 @@ class Window: | |||
| vsync (bool): whether or not vertical sync should be enabled. | |||
| show_window (bool): where or not display the window after initialization. | |||
| """ | |||
| def __init__(self, name, res, vsync=False, show_window=True): | |||
| def __init__(self, name, res, pos=(0, 0), vsync=False, show_window=True): | |||
There was a problem hiding this comment.
If you need to add a kwarg, it'd be better to add it at the end to avoid breaking current api. e.g. if user had Window('test', (512, 512), False, True) it'll be broken by this PR.
Also pos need a proper docstring explaining which window, and where is the origin ;)
for more information, see https://pre-commit.ci
That's right, I will fix that. |
Issue: #6107