Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[example] Request to add my code into examples #6185

Merged
merged 7 commits into from
Sep 30, 2022
Merged

[example] Request to add my code into examples #6185

merged 7 commits into from
Sep 30, 2022

Conversation

JiaoLuhuai
Copy link
Contributor

@JiaoLuhuai JiaoLuhuai commented Sep 27, 2022 •
edited
Loading

I added my code for ti.example. You can see details of my example here
https://forum.taichi.graphics/t/topic/2924

This is a 1D simulation of "two-stream instability" in Plasma Physicis.

@netlify
Copy link

netlify bot commented Sep 27, 2022 •
edited
Loading

✅ Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit c50bf30
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/633656861518ac00080fd754
😎 Deploy Preview https://deploy-preview-6185--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@CLAassistant
Copy link

CLAassistant commented Sep 27, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@JiaoLuhuai JiaoLuhuai changed the title 提交PR: Jiao Luhuai 上传了ti.example投稿的内容 Request to add my code for ti.example Sep 27, 2022
@JiaoLuhuai JiaoLuhuai changed the title Request to add my code for ti.example Request to add my code for Ti example Sep 27, 2022
@JiaoLuhuai JiaoLuhuai changed the title Request to add my code for Ti example Request_to_add_my_code_to_examples Sep 27, 2022
@JiaoLuhuai JiaoLuhuai changed the title Request_to_add_my_code_to_examples Request_to_add_my_code_into_examples Sep 27, 2022
@JiaoLuhuai JiaoLuhuai changed the title Request_to_add_my_code_into_examples Request_to_add_my_code_into_examples.md Sep 27, 2022
@JiaoLuhuai JiaoLuhuai changed the title Request_to_add_my_code_into_examples.md Request to add my code into examples Sep 27, 2022
@JiaoLuhuai JiaoLuhuai changed the title Request to add my code into examples [example] Request to add my code into examples Sep 27, 2022
@neozhaoliang neozhaoliang self-requested a review September 29, 2022 09:41
@neozhaoliang neozhaoliang self-requested a review September 30, 2022 02:32
neozhaoliang
neozhaoliang approved these changes Sep 30, 2022
View reviewed changes
Copy link
Contributor

@neozhaoliang neozhaoliang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@neozhaoliang
Copy link
Contributor

@JiaoLuhuai What does the file name "pic88" mean here? Shall we use a more self-explained name?

@JiaoLuhuai
Copy link
Contributor Author

JiaoLuhuai commented Sep 30, 2022 •
edited
Loading

@JiaoLuhuai What does the file name "pic88" mean here? Shall we use a more self-explained name?

Good idea! I renamed it "two_stream_instability"

neozhaoliang
neozhaoliang approved these changes Sep 30, 2022
View reviewed changes
Copy link
Contributor

@neozhaoliang neozhaoliang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine!

ailzhang
ailzhang approved these changes Sep 30, 2022
View reviewed changes
Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ailzhang ailzhang merged commit afa4259 into taichi-dev:master Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neozhaoliang neozhaoliang neozhaoliang approved these changes

@ailzhang ailzhang ailzhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JiaoLuhuai @CLAassistant @neozhaoliang @ailzhang