[aot] Reorganized C-API headers #6199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsite-preview canceled.
|
PENGUINLIONG
force-pushed
the
capi-header1
branch
from
b2659e7 to
b5f42b7
Compare
jim19930609
reviewed
Oct 11, 2022
jim19930609
reviewed
Oct 11, 2022
PENGUINLIONG
force-pushed
the
capi-header1
branch
from
797884e to
fa9840c
Compare
jim19930609
reviewed
Oct 11, 2022
@jim19930609 sounds good. the entire thing breaks compilation heavily so many changes are made. i'll try chopping'm up |
PENGUINLIONG
changed the title
PENGUINLIONG
force-pushed
the
capi-header1
branch
3 times, most recently
from
a205972 to
a8d5dc6
Compare
[pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Update taichi.h Update taichi.h Reorganized headers Fixed compilation [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Fixed compilation Fixed compilation Fixed compilation Fixed compilation [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci
PENGUINLIONG
force-pushed
the
capi-header1
branch
from
a8d5dc6 to
ff5c1ea
Compare
[pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Update taichi.h Update taichi.h Reorganized headers Fixed compilation [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Fixed compilation Fixed compilation Fixed compilation Fixed compilation [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci
…into capi-header1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @jim19930609 mentioned before including vulkan headers might be contaminating the user namespaces so this PR removes the include and macro. The users should include
vulkan/vulkan.hbeforetaichi/taichi.h.