Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] Fix link error with TI_WITH_OPENGL:BOOL=ON but TI_WITH_VULKAN:BOOL=OFF #6257

Merged
merged 1 commit into from
Oct 9, 2022
Merged

[bug] Fix link error with TI_WITH_OPENGL:BOOL=ON but TI_WITH_VULKAN:BOOL=OFF #6257

merged 1 commit into from
Oct 9, 2022

Conversation

PGZXB
Copy link
Contributor

@PGZXB PGZXB commented Oct 9, 2022 •
edited
Loading

Issue: #6254, #6104

@netlify
Copy link

netlify bot commented Oct 9, 2022 •
edited
Loading

✅ Deploy Preview for docsite-preview canceled.

Name Link
🔨 Latest commit 1d15211
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/6342af7ed656bd0008bcd92b

@PGZXB PGZXB mentioned this pull request Oct 9, 2022
Closed
@PGZXB PGZXB requested a review from neozhaoliang October 9, 2022 12:37
neozhaoliang
neozhaoliang approved these changes Oct 9, 2022
View reviewed changes
Copy link
Contributor

@neozhaoliang neozhaoliang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve this though I cannot reproduce the bug in #6254 😄 :

@neozhaoliang neozhaoliang merged commit a3eb8d1 into taichi-dev:master Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neozhaoliang neozhaoliang neozhaoliang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PGZXB @neozhaoliang