Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ti format cover all files from upstream/master to the working tree #629

Merged
merged 6 commits into from
Mar 20, 2020
Merged

Make ti format cover all files from upstream/master to the working tree #629

merged 6 commits into from
Mar 20, 2020

Conversation

k-ye
Copy link
Member

@k-ye k-ye commented Mar 20, 2020

@k-ye k-ye requested a review from yuanming-hu March 20, 2020 05:46
k-ye
k-ye commented Mar 20, 2020
View reviewed changes
python/taichi/core/util.py Outdated Show resolved Hide resolved
yuanming-hu
yuanming-hu requested changes Mar 20, 2020
View reviewed changes
Copy link
Member

@yuanming-hu yuanming-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! This will be a very helpful improvement. I think it's ready to merge after some minor compatibility issues are fixed.

python/taichi/core/util.py Outdated Show resolved Hide resolved
python/taichi/core/util.py Outdated Show resolved Hide resolved
yuanming-hu
yuanming-hu approved these changes Mar 20, 2020
View reviewed changes
Copy link
Member

@yuanming-hu yuanming-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates. Now everything looks good.

@yuanming-hu yuanming-hu merged commit 2bfa31e into taichi-dev:master Mar 20, 2020
@k-ye k-ye deleted the fmt branch March 20, 2020 23:24
@k-ye k-ye mentioned this pull request Mar 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@archibate archibate archibate left review comments

@yuanming-hu yuanming-hu yuanming-hu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@k-ye @yuanming-hu @archibate