Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vulkan] [bug] Change the format string of 64bit unsigned integer type from %llu to %lu #6308

Merged
merged 7 commits into from
Oct 14, 2022
Merged

[Vulkan] [bug] Change the format string of 64bit unsigned integer type from %llu to %lu #6308

merged 7 commits into from
Oct 14, 2022

Conversation

lin-hitonami
Copy link
Contributor

Issue: fixes #6269

Brief Summary

@netlify
Copy link

netlify bot commented Oct 12, 2022 •
edited
Loading

✅ Deploy Preview for docsite-preview canceled.

Name Link
🔨 Latest commit 01f507f
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/6346b8038ad6c50008977737

ailzhang
ailzhang approved these changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@lin-hitonami
Copy link
Contributor Author

It turns out that Vulkan only supports printing 64-bit unsigned integers, and it does not support 64-bit signed integers...
https://github.com/KhronosGroup/Vulkan-ValidationLayers/blob/master/docs/debug_printf.md

@lin-hitonami lin-hitonami changed the title [Lang] [bug] Change the format string of 64bit integer types from %lld to %ld [Lang] [bug] Change the format string of 64bit integer types from %llu to %lu Oct 12, 2022
@lin-hitonami lin-hitonami changed the title [Lang] [bug] Change the format string of 64bit integer types from %llu to %lu [Lang] [bug] Change the format string of 64bit unsigned integer type from %llu to %lu Oct 12, 2022
@lin-hitonami lin-hitonami changed the title [Lang] [bug] Change the format string of 64bit unsigned integer type from %llu to %lu [Vulkan] [bug] Change the format string of 64bit unsigned integer type from %llu to %lu Oct 12, 2022
@lin-hitonami lin-hitonami requested a review from ailzhang October 13, 2022 02:54
@lin-hitonami lin-hitonami merged commit c0f1242 into taichi-dev:master Oct 14, 2022
@lin-hitonami lin-hitonami deleted the lld branch October 14, 2022 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ailzhang ailzhang Awaiting requested review from ailzhang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Print on Vulkan does not support 64-bit numbers
2 participants
@lin-hitonami @ailzhang