Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Fix cache_loop_invariant_global_vars pass #6462

Merged
merged 3 commits into from
Oct 28, 2022
Merged

[Bug] Fix cache_loop_invariant_global_vars pass #6462

merged 3 commits into from
Oct 28, 2022

Conversation

lin-hitonami
Copy link
Contributor

Issue: fixes #6441

Brief Summary

@netlify
Copy link

netlify bot commented Oct 28, 2022 •
edited
Loading

✅ Deploy Preview for docsite-preview canceled.

Name Link
🔨 Latest commit 4952379
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/635b790f6b45e20009591804

ailzhang
ailzhang approved these changes Oct 28, 2022
View reviewed changes
Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it! I have two nits:

  • is it possible to add a test to prevent a future breakage ;) ?
  • is it a critical bug that requires a bug fix release?

@lin-hitonami
Copy link
Contributor Author

  • is it possible to add a test to prevent a future breakage ;) ?

Yes, I'll add one.

  • is it a critical bug that requires a bug fix release?

I think so.

@ailzhang
Copy link
Contributor

ailzhang commented Oct 28, 2022 •
edited
Loading

is it a critical bug that requires a bug fix release?
I think so.

oops cc: @jim19930609 @feisuzhu

@lin-hitonami lin-hitonami merged commit 00e411e into taichi-dev:master Oct 28, 2022
@lin-hitonami lin-hitonami deleted the fix-lucifer branch October 28, 2022 09:18
jim19930609 pushed a commit to jim19930609/taichi that referenced this pull request Oct 31, 2022
@lin-hitonami @pre-commit-ci @jim19930609
[Bug] Fix cache_loop_invariant_global_vars pass (taichi-dev#6462)
5748722 
Issue: fixes taichi-dev#6441

### Brief Summary

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ailzhang ailzhang ailzhang approved these changes

@jim19930609 jim19930609 Awaiting requested review from jim19930609

@strongoier strongoier Awaiting requested review from strongoier

@turbo0628 turbo0628 Awaiting requested review from turbo0628

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Numerical error with Taichi v1.2.0
2 participants
@lin-hitonami @ailzhang