[bug] Rehash compile config map in advance #6550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsite-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
ailzhang
reviewed
Nov 9, 2022
lin-hitonami
force-pushed
the
fix-flaky
branch
from
3fcac2c to
713ec55
Compare
lin-hitonami
force-pushed
the
fix-flaky
branch
from
713ec55 to
c85e137
Compare
jim19930609
reviewed
Nov 9, 2022
lin-hitonami
force-pushed
the
fix-flaky
branch
from
d75c7b6 to
5012d49
Compare
lin-hitonami
changed the title
|
After rehashing the map in advance, the flaky test never appeared again, and we don't need to add locks. Thanks to @jim19930609 ! |
ailzhang
approved these changes
Nov 9, 2022
for more information, see https://pre-commit.ci
jim19930609
approved these changes
Nov 9, 2022
quadpixels
pushed a commit
to quadpixels/taichi
that referenced
this pull request
May 13, 2023
Issue: fixes taichi-dev#6546 ### Brief Summary I've run the test for 1000 times and the flaky test never appear again. Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: fixes #6546
Brief Summary
I've run the test for 1000 times and the flaky test never appear again.