Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Opt] Merge adjacent if's with the identical condition #668

Merged
merged 4 commits into from
Mar 27, 2020

Conversation

xumingkuan
Copy link
Contributor

@xumingkuan
Copy link
Contributor Author

The number of statements of test_ad_if_mutable reduced from 58 to 54.

@xumingkuan xumingkuan mentioned this pull request Mar 27, 2020
18 tasks
Copy link
Member

@yuanming-hu yuanming-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks. Clearly there's something wrong with the autoformatter, which I'll take a look at now.

@yuanming-hu yuanming-hu merged commit 3ee55d7 into taichi-dev:master Mar 27, 2020
@xumingkuan xumingkuan deleted the if branch March 27, 2020 23:15
archibate pushed a commit to archibate/taichi that referenced this pull request Mar 31, 2020
* Merge adjacent if's with the identical condition

* [skip ci] enforce code format

* simplify using VecStatement

* revert taichi/backend/metal/shaders reformatting

Co-authored-by: Taichi Gardener <taichigardener@gmail.com>
Co-authored-by: Yuanming Hu <yuanmhu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants