[build] Integrate backward_cpp to test targets for enabling C++ stack trace #6697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsite-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
jim19930609
force-pushed
the
backward_cpp
branch
from
964656f to
753193e
Compare
ailzhang
reviewed
Nov 23, 2022
There was a problem hiding this comment.
@jim19930609 instead of coupling with TI_BUILD_TESTS, shall we add a new toggle for backward-cpp itself to make it cleaner?
For example:
- if in CI we just set TI_WITH_BT on by default, and whatever targets (whether they're tests or not) can be built with backward-cpp.
The main reason I'm asking for it is that we may want to build a taichi in debug mode (with backtrace) and it's a bit weird to say we need to turn on TI_BUILD_TESTS which is supposed to only toggle on/off of build test targets?
|
/rebase |
taichi-gardener
force-pushed
the
backward_cpp
branch
from
0e2aef0 to
0bfe0e0
Compare
ailzhang
reviewed
Nov 25, 2022
quadpixels
pushed a commit
to quadpixels/taichi
that referenced
this pull request
May 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #
Brief Summary
When building with
-DTI_BUILD_TESTS=ON,taichi_cpp_tests,taichi_c_api_tests,taichi_python.sowill link to an external library: https://github.com/bombela/backward-cpp, which enables C++ stack trace upon test failures.Segfault with python tests
python3 test.pySegfault with cpp tests
./build/taichi_cpp_testsSegfault with c_api tests
./build/taichi_c_api_tests