Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] Switch Windows build script to build.py #6993

Merged
merged 52 commits into from
Jan 17, 2023
Merged

[ci] Switch Windows build script to build.py #6993

merged 52 commits into from
Jan 17, 2023

Conversation

feisuzhu
Copy link
Contributor

Issue: #6445

Brief Summary

@netlify
Copy link

netlify bot commented Dec 28, 2022 •
edited
Loading

✅ Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit 966b26d
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/63c6744be68dbe000852c938
😎 Deploy Preview https://deploy-preview-6993--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@feisuzhu feisuzhu requested a review from ailzhang January 17, 2023 07:32
@feisuzhu feisuzhu marked this pull request as ready for review January 17, 2023 07:32
ailzhang
ailzhang approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks!

bobcao3
bobcao3 approved these changes Jan 17, 2023
View reviewed changes
Copy link
Collaborator

@bobcao3 bobcao3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@feisuzhu feisuzhu merged commit 437fe47 into taichi-dev:master Jan 17, 2023
@feisuzhu feisuzhu deleted the feat/windows-build branch January 17, 2023 16:17
quadpixels pushed a commit to quadpixels/taichi that referenced this pull request May 13, 2023
@feisuzhu @quadpixels
[ci] Switch Windows build script to build.py (taichi-dev#6993)
1e078f7 
Issue: taichi-dev#6445 

### Brief Summary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobcao3 bobcao3 bobcao3 approved these changes

@ailzhang ailzhang ailzhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@feisuzhu @ailzhang @bobcao3