Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lang] Remove filename kwarg in aot Module save() #7085

Merged

Conversation

ailzhang
Copy link
Contributor

@ailzhang ailzhang commented Jan 6, 2023

Issue: #

Brief Summary

@ailzhang ailzhang marked this pull request as ready for review January 6, 2023 09:41
@netlify
Copy link

netlify bot commented Jan 6, 2023

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit 816776f
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/63bba49fa59e4100082e526c
😎 Deploy Preview https://deploy-preview-7085--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ailzhang ailzhang added this to the v1.4.0 milestone Jan 6, 2023
@ailzhang ailzhang force-pushed the remove_aot_save_deprecation branch 3 times, most recently from ecb96dd to ec6fe3c Compare January 6, 2023 12:44
@ailzhang ailzhang force-pushed the remove_aot_save_deprecation branch from ec6fe3c to 816776f Compare January 9, 2023 05:22
@ailzhang ailzhang requested a review from lin-hitonami January 9, 2023 06:09
Copy link
Contributor

@lin-hitonami lin-hitonami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lin-hitonami lin-hitonami merged commit 042c1e1 into taichi-dev:master Jan 9, 2023
lin-hitonami pushed a commit to lin-hitonami/taichi that referenced this pull request Jan 11, 2023
lin-hitonami pushed a commit to lin-hitonami/taichi that referenced this pull request Jan 12, 2023
quadpixels pushed a commit to quadpixels/taichi that referenced this pull request May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants