Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[metal] Disable a kernel test in offline cache to unblock CI #7154

Merged
merged 2 commits into from
Jan 18, 2023

Conversation

ailzhang
Copy link
Contributor

@ailzhang ailzhang commented Jan 13, 2023

Issue: #6221

Brief Summary

kernel4 in test_offline_cache.py triggers a weird LLVM internal error on metal backend for macos12+. After moving metal runtime to gfxruntime by @PENGUINLIONG and #7201, this is now the only blocker for us to run full CI on macos ventura. As discussed with @PENGUINLIONG and @feisuzhu offline, let's disable this test to unblock CI and add it back once the issue is fixed.

@netlify
Copy link

netlify bot commented Jan 13, 2023

Deploy Preview for docsite-preview canceled.

Name Link
🔨 Latest commit d97f7d4
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/63c756d2bcff9c0009b06007

@ailzhang
Copy link
Contributor Author

/rebase

@ailzhang
Copy link
Contributor Author

@feisuzhu I've rerun the m1 job on ventura multiple times and it seems that the flakiness is gone :D
Once this PR is merged, how about we add ventura machine to m1 builtbots as well?

Copy link
Contributor

@PGZXB PGZXB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@feisuzhu feisuzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@ailzhang ailzhang merged commit e84b2d0 into taichi-dev:master Jan 18, 2023
quadpixels pushed a commit to quadpixels/taichi that referenced this pull request May 13, 2023
…dev#7154)

Issue: taichi-dev#6221 

### Brief Summary

`kernel4` in `test_offline_cache.py` triggers a weird LLVM internal
error on metal backend for macos12+. After moving metal runtime to
gfxruntime by @PENGUINLIONG and taichi-dev#7201, this is now the only blocker for
us to run full CI on macos ventura. As discussed with @PENGUINLIONG and
@feisuzhu offline, let's disable this test to unblock CI and add it back
once the issue is fixed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants