Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lang] Add validation checks for subscripts to reject negative indices #7212

Merged
merged 3 commits into from
Jan 28, 2023

Conversation

jim19930609
Copy link
Contributor

@jim19930609 jim19930609 commented Jan 19, 2023

Issue: fix #7096

Brief Summary

@netlify
Copy link

netlify bot commented Jan 19, 2023

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit 1e9db9f
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/63c93cdbb06cef00080e7c76
😎 Deploy Preview https://deploy-preview-7212--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ailzhang
Copy link
Contributor

/rebase

@jim19930609 jim19930609 requested review from strongoier and ailzhang and removed request for strongoier January 20, 2023 03:28
@bobcao3 bobcao3 changed the title [lang] Add validation checks for subscriptions to reject negative indices [lang] Add validation checks for subscripts to reject negative indices Jan 27, 2023
@jim19930609 jim19930609 merged commit 3ac2976 into taichi-dev:master Jan 28, 2023
quadpixels pushed a commit to quadpixels/taichi that referenced this pull request May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slicing vectors with negative indices returns wrong result
3 participants