[aot] Fix ndarray aot with information from type hints #7214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsite-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
ailzhang
force-pushed
the
fix_aot_without_template_arg
branch
3 times, most recently
from
da3fd35 to
0713d97
Compare
|
/rebase |
Ideally we should reconstruct the dtype to the Tensortype from taichi_core instead of python ones but that can be a separate PR.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
taichi-gardener
force-pushed
the
fix_aot_without_template_arg
branch
from
b912eb1 to
4012189
Compare
PENGUINLIONG
approved these changes
Jan 20, 2023
|
@PENGUINLIONG sure thing, will send a followup PR for it! |
quadpixels
pushed a commit
to quadpixels/taichi
that referenced
this pull request
May 13, 2023
Issue: fixes taichi-dev#7172 ### Brief Summary Ideally we should reconstruct the dtype to the Tensortype from taichi_core instead of python ones but that can be a separate PR. Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: fixes #7172
Brief Summary
Ideally we should reconstruct the dtype to the Tensortype from taichi_core instead of python ones but that can be a separate PR.