Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[examples] Remove dependency on ti.u8 compute type for ngp #7220

Merged
merged 2 commits into from
Jan 22, 2023

Conversation

bobcao3
Copy link
Collaborator

@bobcao3 bobcao3 commented Jan 20, 2023

Brief Summary

Many backends support half / float16, but in comparison int8 has very pretty bad support in general. This change enables backends like opengl and dx12 to run this demo (assuming the feature-enabling PR is also merged in those)

@netlify
Copy link

netlify bot commented Jan 20, 2023

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit f79c35a
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/63c9fc6188152100082231b8
😎 Deploy Preview https://deploy-preview-7220--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@bobcao3 bobcao3 changed the title [examples] Remove dependency on ti.u8 compute type for ngp [example] Remove dependency on ti.u8 compute type for ngp Jan 20, 2023
@bobcao3 bobcao3 changed the title [example] Remove dependency on ti.u8 compute type for ngp [examples] Remove dependency on ti.u8 compute type for ngp Jan 20, 2023
@bobcao3 bobcao3 requested a review from ailzhang January 20, 2023 09:57
Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ailzhang ailzhang merged commit b48baeb into taichi-dev:master Jan 22, 2023
quadpixels pushed a commit to quadpixels/taichi that referenced this pull request May 13, 2023
…dev#7220)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants