Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Update ndarray.md #7236

Merged
merged 2 commits into from
Jan 28, 2023
Merged

[DOC] Update ndarray.md #7236

merged 2 commits into from
Jan 28, 2023

Conversation

vai9er
Copy link
Contributor

@vai9er vai9er commented Jan 26, 2023

No description provided.

@netlify
Copy link

netlify bot commented Jan 26, 2023

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit 723de21
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/63d4ba3da483ec0008ffcb9f
😎 Deploy Preview https://deploy-preview-7236--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@vai9er vai9er changed the title Update ndarray.md [DOC] Update ndarray.md Jan 26, 2023
Copy link
Contributor

@neozhaoliang neozhaoliang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@Olinaaaloompa Olinaaaloompa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix dangling modifiers. Also, we tend to use the present tense throughout even in conditional sentences to imply that something always happens, but we can discuss it later :)
Otherwise, it LGTM! Thanks!

docs/lang/articles/basic/ndarray.md Outdated Show resolved Hide resolved
@neozhaoliang neozhaoliang merged commit 83e6d1e into taichi-dev:master Jan 28, 2023
quadpixels pushed a commit to quadpixels/taichi that referenced this pull request May 13, 2023
Co-authored-by: Olinaaaloompa <106292061+Olinaaaloompa@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants