Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Update write_test.md #7745

Merged
merged 2 commits into from
Apr 6, 2023
Merged

[Doc] Update write_test.md #7745

merged 2 commits into from
Apr 6, 2023

Conversation

houkensjtu
Copy link
Contributor

Mention to reader that they need to install dependencies before running tests.

Mention to reader that they need to install dependencies before running tests.
@netlify
Copy link

netlify bot commented Apr 6, 2023

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit 30af700
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/642e4075d7b07f00085209f6
😎 Deploy Preview https://deploy-preview-7745--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@houkensjtu houkensjtu changed the title Update write_test.md [Doc] Update write_test.md Apr 6, 2023
@houkensjtu houkensjtu requested a review from feisuzhu April 6, 2023 03:23
@houkensjtu houkensjtu requested a review from neozhaoliang April 6, 2023 03:23
Copy link
Contributor

@feisuzhu feisuzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test

Copy link
Contributor

@feisuzhu feisuzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest are LGTM.

Copy link
Contributor

@neozhaoliang neozhaoliang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@houkensjtu houkensjtu merged commit 2366ea4 into master Apr 6, 2023
@houkensjtu houkensjtu deleted the houkensjtu-doc-write-tests branch April 6, 2023 06:38
quadpixels pushed a commit to quadpixels/taichi that referenced this pull request May 13, 2023
Mention to reader that they need to install dependencies before running
tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants