Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] Split Program::compile() #7847

Merged
merged 5 commits into from
Apr 21, 2023

Conversation

PGZXB
Copy link
Contributor

@PGZXB PGZXB commented Apr 19, 2023

Issue: #7002

Brief Summary

Program::compile() => Program::compile_kernel() + Program::launch_kernel()

@netlify
Copy link

netlify bot commented Apr 19, 2023

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit 25fb9ce
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/6441fc34d2330f0008805237
😎 Deploy Preview https://deploy-preview-7847--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@PGZXB PGZXB requested review from ailzhang and lin-hitonami April 19, 2023 10:33
Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except some nits!

taichi/program/snode_rw_accessors_bank.cpp Outdated Show resolved Hide resolved
taichi/program/snode_rw_accessors_bank.cpp Outdated Show resolved Hide resolved
@PGZXB PGZXB merged commit 570d249 into taichi-dev:master Apr 21, 2023
quadpixels pushed a commit to quadpixels/taichi that referenced this pull request May 13, 2023
Issue: taichi-dev#7002

### Brief Summary

`Program::compile()` => `Program::compile_kernel()` +
`Program::launch_kernel()`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants