[Error] Update deprecation warning of the graph arguments #7965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsite-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
feisuzhu
pushed a commit
that referenced
this pull request
May 10, 2023
Issue: # ### Brief Summary <!-- copilot:summary --> ### <samp>🤖 Generated by Copilot at 0419745</samp> This pull request improves the deprecation warning messages for some arguments in the `ti.graph` module and updates the corresponding tests. The goal is to inform the users of the upcoming API changes and guide them to use the `ti.graph` module correctly. ### Walkthrough <!-- copilot:walkthrough --> ### <samp>🤖 Generated by Copilot at 0419745</samp> * Update the deprecation warning messages for the `element_shape`, `shape`, `channel_format`, and `num_channels` arguments for scalar, ndarray, texture, and RWTexture to reflect the new version number and the removal policy ([link](https://github.com/taichi-dev/taichi/pull/7965/files?diff=unified&w=0#diff-3b3dff33121c57d33ae7fd0a1288da627f08baed4cdb4039882cc397a2107c0cL118-R119), [link](https://github.com/taichi-dev/taichi/pull/7965/files?diff=unified&w=0#diff-3b3dff33121c57d33ae7fd0a1288da627f08baed4cdb4039882cc397a2107c0cL134-R136), [link](https://github.com/taichi-dev/taichi/pull/7965/files?diff=unified&w=0#diff-3b3dff33121c57d33ae7fd0a1288da627f08baed4cdb4039882cc397a2107c0cL152-R155), [link](https://github.com/taichi-dev/taichi/pull/7965/files?diff=unified&w=0#diff-3b3dff33121c57d33ae7fd0a1288da627f08baed4cdb4039882cc397a2107c0cL167-R177)) * Update the test cases for the deprecation warning messages in `test_deprecation.py` to match the new messages and verify the expected behavior ([link](https://github.com/taichi-dev/taichi/pull/7965/files?diff=unified&w=0#diff-8981be068a363e39524dc2e29d28d4c13a097d0037fc3a1176b249ce5bf35ef8L15-R16), [link](https://github.com/taichi-dev/taichi/pull/7965/files?diff=unified&w=0#diff-8981be068a363e39524dc2e29d28d4c13a097d0037fc3a1176b249ce5bf35ef8L24-R26), [link](https://github.com/taichi-dev/taichi/pull/7965/files?diff=unified&w=0#diff-8981be068a363e39524dc2e29d28d4c13a097d0037fc3a1176b249ce5bf35ef8L33-R36), [link](https://github.com/taichi-dev/taichi/pull/7965/files?diff=unified&w=0#diff-8981be068a363e39524dc2e29d28d4c13a097d0037fc3a1176b249ce5bf35ef8L42-R46), [link](https://github.com/taichi-dev/taichi/pull/7965/files?diff=unified&w=0#diff-8981be068a363e39524dc2e29d28d4c13a097d0037fc3a1176b249ce5bf35ef8L57-R62), [link](https://github.com/taichi-dev/taichi/pull/7965/files?diff=unified&w=0#diff-8981be068a363e39524dc2e29d28d4c13a097d0037fc3a1176b249ce5bf35ef8L66-R72))
quadpixels
pushed a commit
to quadpixels/taichi
that referenced
this pull request
May 13, 2023
…#7965) Issue: # ### Brief Summary <!-- copilot:summary --> ### <samp>🤖 Generated by Copilot at 0419745</samp> This pull request improves the deprecation warning messages for some arguments in the `ti.graph` module and updates the corresponding tests. The goal is to inform the users of the upcoming API changes and guide them to use the `ti.graph` module correctly. ### Walkthrough <!-- copilot:walkthrough --> ### <samp>🤖 Generated by Copilot at 0419745</samp> * Update the deprecation warning messages for the `element_shape`, `shape`, `channel_format`, and `num_channels` arguments for scalar, ndarray, texture, and RWTexture to reflect the new version number and the removal policy ([link](https://github.com/taichi-dev/taichi/pull/7965/files?diff=unified&w=0#diff-3b3dff33121c57d33ae7fd0a1288da627f08baed4cdb4039882cc397a2107c0cL118-R119), [link](https://github.com/taichi-dev/taichi/pull/7965/files?diff=unified&w=0#diff-3b3dff33121c57d33ae7fd0a1288da627f08baed4cdb4039882cc397a2107c0cL134-R136), [link](https://github.com/taichi-dev/taichi/pull/7965/files?diff=unified&w=0#diff-3b3dff33121c57d33ae7fd0a1288da627f08baed4cdb4039882cc397a2107c0cL152-R155), [link](https://github.com/taichi-dev/taichi/pull/7965/files?diff=unified&w=0#diff-3b3dff33121c57d33ae7fd0a1288da627f08baed4cdb4039882cc397a2107c0cL167-R177)) * Update the test cases for the deprecation warning messages in `test_deprecation.py` to match the new messages and verify the expected behavior ([link](https://github.com/taichi-dev/taichi/pull/7965/files?diff=unified&w=0#diff-8981be068a363e39524dc2e29d28d4c13a097d0037fc3a1176b249ce5bf35ef8L15-R16), [link](https://github.com/taichi-dev/taichi/pull/7965/files?diff=unified&w=0#diff-8981be068a363e39524dc2e29d28d4c13a097d0037fc3a1176b249ce5bf35ef8L24-R26), [link](https://github.com/taichi-dev/taichi/pull/7965/files?diff=unified&w=0#diff-8981be068a363e39524dc2e29d28d4c13a097d0037fc3a1176b249ce5bf35ef8L33-R36), [link](https://github.com/taichi-dev/taichi/pull/7965/files?diff=unified&w=0#diff-8981be068a363e39524dc2e29d28d4c13a097d0037fc3a1176b249ce5bf35ef8L42-R46), [link](https://github.com/taichi-dev/taichi/pull/7965/files?diff=unified&w=0#diff-8981be068a363e39524dc2e29d28d4c13a097d0037fc3a1176b249ce5bf35ef8L57-R62), [link](https://github.com/taichi-dev/taichi/pull/7965/files?diff=unified&w=0#diff-8981be068a363e39524dc2e29d28d4c13a097d0037fc3a1176b249ce5bf35ef8L66-R72))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #
Brief Summary
🤖 Generated by Copilot at 0419745
This pull request improves the deprecation warning messages for some arguments in the
ti.graphmodule and updates the corresponding tests. The goal is to inform the users of the upcoming API changes and guide them to use theti.graphmodule correctly.Walkthrough
🤖 Generated by Copilot at 0419745
element_shape,shape,channel_format, andnum_channelsarguments for scalar, ndarray, texture, and RWTexture to reflect the new version number and the removal policy (link, link, link, link)test_deprecation.pyto match the new messages and verify the expected behavior (link, link, link, link, link, link)