[test] Fix previous discovered flaky test_sparse_linear_solver.py. #8110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsite-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
for more information, see https://pre-commit.ci
ailzhang
reviewed
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #8045
Brief Summary
test_sparse_linear_solver.pyfailed randomly before as reported in issue #8045. The reason for the failures was two-fold:dtypewas not aligned between theSparseMatrixBuilderand theSparseSolver, that caused 95% of the failures.With this PR fixing both of the issues,
test_sparse_linear_solver.pyshould pass robustly enough.Additional Comment
Note that with this PR, the two tests that were skipped before (
test_gpu_sparse_solverandtest_gpu_sparse_solver2) now come back. @ailzhang