Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Add taichiCourse01 & marching_squares release tests #8157

Merged
merged 2 commits into from
Jun 21, 2023

Conversation

L2ncE
Copy link
Contributor

@L2ncE L2ncE commented Jun 8, 2023

Issue: #5741

Brief Summary

🤖 Generated by Copilot at bc9de83

This pull request adds tests for more taichi examples and features from external repositories in taichiCourse01. It updates the test scripts for both Unix and Windows platforms to clone and install the necessary dependencies and run the tests.

Walkthrough

🤖 Generated by Copilot at bc9de83

  • Add six git clone commands to download additional repositories from taichiCourse01 in both unix_test.sh and win_test.ps1 scripts (link, link)
  • Add six pairs of pushd and popd commands to install the requirements for each of the cloned repositories using pip in both unix_test.sh and win_test.ps1 scripts (link, link)
  • Modify the existing code in win_test.ps1 to match the changes in unix_test.sh for running the tests on different platforms (link)

@L2ncE L2ncE requested a review from feisuzhu June 8, 2023 06:29
@netlify
Copy link

netlify bot commented Jun 8, 2023

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit 373e32c
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/6491b582ba0e150008dbc527
😎 Deploy Preview https://deploy-preview-8157--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@L2ncE L2ncE changed the title [ci] add taichiCourse01 release tests [ci] Add taichiCourse01 release tests Jun 8, 2023
@L2ncE L2ncE marked this pull request as draft June 8, 2023 07:59
@L2ncE L2ncE force-pushed the ci/add_taichiCourse01_release_tests branch from bc9de83 to 33a17ec Compare June 8, 2023 08:07
Copy link
Contributor

@feisuzhu feisuzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@L2ncE
Copy link
Contributor Author

L2ncE commented Jun 8, 2023

LGTM!

After fixing the failure caused by taichi_sph/demo.py, I will change the Draft status to Ready for review

@L2ncE
Copy link
Contributor Author

L2ncE commented Jun 13, 2023

waiting for taichiCourse01/taichi_sph#2

@L2ncE L2ncE changed the title [ci] Add taichiCourse01 release tests [ci] Add taichiCourse01 & marching_squares release tests Jun 19, 2023
@L2ncE
Copy link
Contributor Author

L2ncE commented Jun 19, 2023

Ignore taichi_sph for now and add marching squares

@L2ncE L2ncE marked this pull request as ready for review June 19, 2023 07:16
@L2ncE L2ncE force-pushed the ci/add_taichiCourse01_release_tests branch from 6d4a3d5 to daf4485 Compare June 19, 2023 07:37
@L2ncE L2ncE force-pushed the ci/add_taichiCourse01_release_tests branch from daf4485 to 373e32c Compare June 19, 2023 07:52
@L2ncE L2ncE marked this pull request as draft June 19, 2023 08:20
@L2ncE L2ncE marked this pull request as ready for review June 20, 2023 09:24
@L2ncE L2ncE force-pushed the ci/add_taichiCourse01_release_tests branch 2 times, most recently from 3ca80cd to 373e32c Compare June 20, 2023 14:19
@L2ncE
Copy link
Contributor Author

L2ncE commented Jun 21, 2023

/rerun-failed

@feisuzhu feisuzhu merged commit 4eb2cff into taichi-dev:master Jun 21, 2023
@L2ncE L2ncE deleted the ci/add_taichiCourse01_release_tests branch June 21, 2023 02:43
PGZXB pushed a commit to PGZXB/taichi that referenced this pull request Jul 13, 2023
…8157)

Issue: taichi-dev#5741 

### Brief Summary

<!--
copilot:summary
-->
### <samp>🤖 Generated by Copilot at bc9de83</samp>

This pull request adds tests for more taichi examples and features from
external repositories in `taichiCourse01`. It updates the test scripts
for both Unix and Windows platforms to clone and install the necessary
dependencies and run the tests.

### Walkthrough

<!--
copilot:walkthrough
-->
### <samp>🤖 Generated by Copilot at bc9de83</samp>

* Add six git clone commands to download additional repositories from
taichiCourse01 in both `unix_test.sh` and `win_test.ps1` scripts
([link](https://github.com/taichi-dev/taichi/pull/8157/files?diff=unified&w=0#diff-34fa2bad51121dca1ec0d22993a5d102611b68b6466589d40a651b955ea67ca3R56-R61),
[link](https://github.com/taichi-dev/taichi/pull/8157/files?diff=unified&w=0#diff-1e56d5e9fca9a2bd938d65c6735714636f8d236462ae1167ca97e3c1a166cf54L98-R125))
* Add six pairs of pushd and popd commands to install the requirements
for each of the cloned repositories using pip in both `unix_test.sh` and
`win_test.ps1` scripts
([link](https://github.com/taichi-dev/taichi/pull/8157/files?diff=unified&w=0#diff-34fa2bad51121dca1ec0d22993a5d102611b68b6466589d40a651b955ea67ca3R68-R91),
[link](https://github.com/taichi-dev/taichi/pull/8157/files?diff=unified&w=0#diff-1e56d5e9fca9a2bd938d65c6735714636f8d236462ae1167ca97e3c1a166cf54L98-R125))
* Modify the existing code in `win_test.ps1` to match the changes in
`unix_test.sh` for running the tests on different platforms
([link](https://github.com/taichi-dev/taichi/pull/8157/files?diff=unified&w=0#diff-1e56d5e9fca9a2bd938d65c6735714636f8d236462ae1167ca97e3c1a166cf54L98-R125))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants