[Lang] Support vector/matrix ndarray arguments in real function #8231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
This was referenced Jun 27, 2023
…ction" [ghstack-poisoned]
jim19930609
approved these changes
Jun 29, 2023
taichi-gardener
pushed a commit
that referenced
this pull request
Jun 29, 2023
ghstack-source-id: 8aad3bdb368cdad5f6627d819bf5bdc86353ffcb Pull Request resolved: #8231
PGZXB
pushed a commit
to PGZXB/taichi
that referenced
this pull request
Jul 13, 2023
ghstack-source-id: 8aad3bdb368cdad5f6627d819bf5bdc86353ffcb Pull Request resolved: taichi-dev#8231
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
expand_exprsto expand the ndarray struct doesn't work when the ndarray element type is a tensor.So I added
ExternalTensorBasePtrExpressionto get the base ptr of the ndarray and its grad.Stack from ghstack (oldest at bottom):