[Bug] Fix Erroneous handling of ndarray in real function in CFG #8245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsite-preview canceled.
|
lin-hitonami
force-pushed
the
fix-ndarray-cfg
branch
from
ba828dc to
b561a2c
Compare
ailzhang
approved these changes
Jun 30, 2023
PGZXB
pushed a commit
to PGZXB/taichi
that referenced
this pull request
Jul 13, 2023
…hi-dev#8245) Issue: # `arg_id` doesn't make sense when two statements come from different callables. Therefore we cannot decide whether a `ExternalPtrStmt` in the real function points to the same ndarray as another `ExternalPtrStmt` in the kernel by checking the `arg_id` of them. Instead, we can assume that all ndarrays passed into a real function can be modified. When a ndarray is passed into a real function, a `ExternalTensorBasePtrStmt` is inserted into the argument of the real function, which will appear in the store destinations of the `FuncCallStmt`. Then, we can add support for it in the alias analysis. We also don't include the `ExternalPtrStmt`s in the real functions in the store destination sets as they don't make any sense. ### Brief Summary <!-- copilot:summary --> ### <samp>🤖 Generated by Copilot at ba828dc</samp> Add support for real functions writing to external arrays or tensors. Update alias analysis and store destination collection to handle external pointers. Add a test case for the new feature. ### Walkthrough <!-- copilot:walkthrough --> ### <samp>🤖 Generated by Copilot at ba828dc</samp> * Add a special case for alias analysis of external tensor base pointers ([link](https://github.com/taichi-dev/taichi/pull/8245/files?diff=unified&w=0#diff-de599d158682f1f0209f39aa58631d6df8d8ded1eacb00d7d6c5200ef7391793R17-R38)) * Skip external pointers and matrix pointers from external pointers when gathering store destinations of a function ([link](https://github.com/taichi-dev/taichi/pull/8245/files?diff=unified&w=0#diff-0bfbe49ff08844a76d5d2e1c5b81c2cf813be4a9089422b997bc380ec9a68eadL65-R75)) * Add a test case for real functions writing to external arrays or tensors in `test_ndarray.py` ([link](https://github.com/taichi-dev/taichi/pull/8245/files?diff=unified&w=0#diff-ca3c8d1edb25b6a7f4affbb79b2e3e74f73b3757e5d465258ce42ea9eb09fbc0R1132-R1150))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #
arg_iddoesn't make sense when two statements come from different callables. Therefore we cannot decide whether aExternalPtrStmtin the real function points to the same ndarray as anotherExternalPtrStmtin the kernel by checking thearg_idof them.Instead, we can assume that all ndarrays passed into a real function can be modified. When a ndarray is passed into a real function, a
ExternalTensorBasePtrStmtis inserted into the argument of the real function, which will appear in the store destinations of theFuncCallStmt. Then, we can add support for it in the alias analysis. We also don't include theExternalPtrStmts in the real functions in the store destination sets as they don't make any sense.Brief Summary
🤖 Generated by Copilot at ba828dc
Add support for real functions writing to external arrays or tensors. Update alias analysis and store destination collection to handle external pointers. Add a test case for the new feature.
Walkthrough
🤖 Generated by Copilot at ba828dc
test_ndarray.py(link)