Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[opt] Eliminate WhileControlStmt with non-zero const conditions #829

Merged
merged 1 commit into from
Apr 20, 2020

Conversation

xumingkuan
Copy link
Contributor

Related issue = #656

I put it in alg_simp.cpp since there seem to be no better places.

I thought I found

<i32 x1> $5 = const [1]
$6 : while control nullptr, $5

in some files like test_for_break.py, but I can't find such IRs now... This PR doesn't reduce the number of statements for any tests in test_for_break.py.

[Click here for the format server]

@xumingkuan xumingkuan requested a review from yuanming-hu April 20, 2020 22:09
@xumingkuan xumingkuan mentioned this pull request Apr 20, 2020
18 tasks
Copy link
Member

@yuanming-hu yuanming-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks!

@yuanming-hu yuanming-hu merged commit 24009bb into taichi-dev:master Apr 20, 2020
@xumingkuan xumingkuan deleted the while-control branch April 27, 2020 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants