Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Fix build.py Powershell part. #8291

Merged

Conversation

houkensjtu
Copy link
Contributor

Issue: #

Brief Summary

"-Interactive" seems not to be a valid argument for the current Powershell. On my Windows 11 machine, invoke python build.py --shell gives the following error:

image

This PR removes the "-Interactive" flag, and add a "ExecutionPolicy" flag which is required for running the remaining part of the build.py script.

@houkensjtu houkensjtu requested a review from feisuzhu July 18, 2023 07:57
@netlify
Copy link

netlify bot commented Jul 18, 2023

Deploy Preview for docsite-preview canceled.

Name Link
🔨 Latest commit 0b532b8
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/64b645fd9a2c07000849e227

Copy link
Contributor

@feisuzhu feisuzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@houkensjtu houkensjtu merged commit 632584f into taichi-dev:master Jul 18, 2023
@houkensjtu
Copy link
Contributor Author

Just for reference, I've also confirmed that this PR works in both Powershell ver 7.3 and ver 5.1. -Interactive is a valid argument in 7.3 but not in 5.1, therefore it's safer not to use -Interactive when invoking the powershell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants