[Lang] Remove deprecated graph arguments #8410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsite-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This was referenced Nov 20, 2023
jim19930609
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #
Brief Summary
🤖[deprecated] Generated by Copilot at 85f2609
Remove and test deprecated arguments for graph nodes. The pull request removes the
argsandkwargsarguments from theNodeclass and its subclasses in_graph.py, and raises an error if they are used. It also updates thetest_deprecation.pyfile to check for the error instead of a warning.Walkthrough
🤖[deprecated] Generated by Copilot at 85f2609
TaichiRuntimeErrorinstead ofDeprecationWarning(link, link, link, link) in the_deprecate_arg_argsfunction ofpython/taichi/graph/_graph.pytests/python/test_deprecation.pyto expectTaichiRuntimeErrorinstead ofDeprecationWarningfor scalar, ndarray, and texture arguments with deprecated arguments (link, link, link, link, link, link)