Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[misc] Add flag to disable taichi header print #8413

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

chaoming0625
Copy link
Contributor

@chaoming0625 chaoming0625 commented Nov 20, 2023

Issue: #8334

Brief Summary

Add a flag to disable Taichi header print. One can set os.environ['ENABLE_TAICHI_HEADER_PRINT'] = False to disable the header print.

🤖[deprecated] Generated by Copilot at 65548e0

Add an option to disable Taichi header printing using an environment variable. Modify python/taichi/_lib/utils.py to implement the option.

Walkthrough

🤖[deprecated] Generated by Copilot at 65548e0

  • Add a conditional check to enable or disable the Taichi header printing (link)
  • Use an environment variable ENABLE_TAICI_HEADER_PRINT to control the check (link)

Copy link

netlify bot commented Nov 20, 2023

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit 939ccd4
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/655aceb21055600008d17d71
😎 Deploy Preview https://deploy-preview-8413--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@CLAassistant
Copy link

CLAassistant commented Nov 20, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@lin-hitonami lin-hitonami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lin-hitonami lin-hitonami changed the title Add flag to disable taichi header print. [misc] Add flag to disable taichi header print Nov 27, 2023
@lin-hitonami lin-hitonami merged commit 59156b3 into taichi-dev:master Nov 27, 2023
28 of 29 checks passed
bobcao3 pushed a commit that referenced this pull request Jun 23, 2024
Issue: #8334 

### Brief Summary

The previous code #8413 had no effect because the value in os.environ
can only be a string. This pull request will enable users to disable the
Taichi header print by setting one of the following ways:

- os.environ['ENABLE_TAICHI_HEADER_PRINT'] = 'False'
- os.environ['ENABLE_TAICHI_HEADER_PRINT'] = 'FALSE'
- os.environ['ENABLE_TAICHI_HEADER_PRINT'] = 'F'
- os.environ['ENABLE_TAICHI_HEADER_PRINT'] = '0'

### Walkthrough

copilot:walkthrough

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants