Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[misc] Fix imread not reading properly when image is not equal in height and width #855

Merged
merged 3 commits into from
Apr 25, 2020
Merged

[misc] Fix imread not reading properly when image is not equal in height and width #855

merged 3 commits into from
Apr 25, 2020

Conversation

archibate
Copy link
Collaborator

@archibate archibate requested a review from yuanming-hu April 23, 2020 15:29
@yuanming-hu yuanming-hu changed the title [misc] fix imread not reading properly when image is not equal in height and width [misc] Fix imread not reading properly when image is not equal in height and width Apr 23, 2020
yuanming-hu
yuanming-hu approved these changes Apr 24, 2020
View reviewed changes
Copy link
Member

@yuanming-hu yuanming-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@yuanming-hu
Copy link
Member

You should have write access to the repository now. Feel free to merge PRs with at least one approval from the reviewers. Please keep these in mind:

  • With great power comes great responsibility.
  • Please try to act as a professional team worker, as much as you can. Be considerate of other team members.
  • Please do follow the contributor guidelines. If you don't follow, that's a very bad example for other people without write access. The Taichi community reserves the right of revoking write access.
  • Please make sure the first letter of the PR description is capitalized. For example, the title of this PR should be [misc] Fix imread ... instead of [misc] fix imread ....

Receiving write permission is great recognition from the community. Congrats!

@archibate archibate merged commit ef0c336 into taichi-dev:master Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuanming-hu yuanming-hu yuanming-hu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@archibate @yuanming-hu