-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[opt] Eliminate useless local stores and atomics #858
Conversation
Wait... there may be issues when it comes into
|
The logic here is getting too complex and the correctness is no longer trivial. Refactoring is needed here, otherwise, nobody other than you can understand what this part is doing... Is seems that you are simulating a state machine here - maybe we should extract this part of logic. Given we are rushing for the deadline next week, this can be merged for now if nothing breaks, but we should revisit later after the deadline. |
Yes... In order to eliminate |
Related issue = #656
gather_used_atomics
can be utilized in #857.Benchmark:
before:
after: nothing changed.
after adding a test...:
[Click here for the format server]