Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[misc] Fix ti.cfg.gdb_trigger not found #879

Merged
merged 1 commit into from
Apr 26, 2020
Merged

[misc] Fix ti.cfg.gdb_trigger not found #879

merged 1 commit into from
Apr 26, 2020

Conversation

archibate
Copy link
Collaborator

@archibate archibate commented Apr 26, 2020 •
edited
Loading

Related PR id = #769

[Click here for the format server]

I made an error in #769: there is no ti.cfg.gdb_trigger at all!
Now the problem is where should gdb_trigger be, CompileConfig or CoreState?
The first seems only accessible only by compiler parts. So get_current_program().config stand for only compiler configuations so it's not found anywhere in logger.cpp?

@archibate archibate changed the title [misc] move gdb_trigger to program.config [misc] Move CoreState::get_instance().gdb_trigger to program.config Apr 26, 2020
@archibate
Copy link
Collaborator Author

archibate commented Apr 26, 2020 •
edited
Loading

I realized that in test_assert.py, you set gdb trigger to False. And that is applied to other test threads too. (if I'm understanding correct) So it should be moved into program.config which is per-thread?

@archibate archibate self-assigned this Apr 26, 2020
@archibate archibate changed the title [misc] Move CoreState::get_instance().gdb_trigger to program.config [misc] Fix ti.cfg.gdb_trigger not found Apr 26, 2020
@archibate archibate added the P0 This issue is urgent to be solved and has highest priority label Apr 26, 2020
@archibate archibate requested a review from xumingkuan April 26, 2020 07:55
@archibate archibate marked this pull request as ready for review April 26, 2020 07:56
@archibate
Copy link
Collaborator Author

CI passing! I'm merging this now to prevent other problem if users fork from master. Sorry for introducing an error in master branch.. I guess will soon be revoked from write-access if I keep merging failure codes into master...

@archibate archibate merged commit 0131475 into taichi-dev:master Apr 26, 2020
@archibate archibate mentioned this pull request Apr 26, 2020
Merged
xumingkuan
xumingkuan reviewed Apr 26, 2020
View reviewed changes
Copy link
Contributor

@xumingkuan xumingkuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ti.set_gdb_trigger is used in many other places in the code. It's fine to not use environ_config for gdb_trigger here :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xumingkuan xumingkuan xumingkuan left review comments

Assignees

@archibate archibate

Labels
P0 This issue is urgent to be solved and has highest priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@archibate @xumingkuan