[Doc] Add documentions for layout #900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-ye
reviewed
Apr 29, 2020
archibate
commented
Apr 30, 2020
yuanming-hu
requested changes
May 1, 2020
archibate
commented
May 2, 2020
archibate
commented
May 2, 2020
|
Hello? Could you provide more infomation about dynamic snode? |
k-ye
reviewed
May 10, 2020
k-ye
reviewed
May 10, 2020
k-ye
reviewed
May 10, 2020
k-ye
reviewed
May 10, 2020
k-ye
reviewed
May 10, 2020
k-ye
reviewed
May 10, 2020
k-ye
reviewed
May 10, 2020
k-ye
reviewed
May 10, 2020
| val = ti.var(ti.f32) | ||
| ti.root.dense(ti.ijk, (8, 16, 32)).dense(ti.ijk, (4, 4, 4)).place(val) | ||
|
|
||
| This organizes ``val`` in ``4x4x4`` blocks, so that with high probability ``val[i, j, k]`` and its neighbours are close to each other (i.e., in the same cacheline or memory page). |
There was a problem hiding this comment.
Suggested change
| This organizes ``val`` in ``4x4x4`` blocks, so that with high probability ``val[i, j, k]`` and its neighbours are close to each other (i.e., in the same cacheline or memory page). | |
| This organizes ``val`` in ``4x4x4`` blocks, so that with high probability ``val[i, j, k]`` and its neighbours are close to each other (i.e., in the same memoy page or even cacheline). |
There was a problem hiding this comment.
Refuse, typo memoy -> memory.
There was a problem hiding this comment.
My point is that memory should come before cacheline
k-ye
reviewed
May 10, 2020
| for i, j in A: | ||
| A[i, j] += 1 | ||
|
|
||
| will iterate over elements of ``A`` following row-major order. If ``A`` is column-major, then the iteration follows the column-major order. |
There was a problem hiding this comment.
Suggested change
| will iterate over elements of ``A`` following row-major order. If ``A`` is column-major, then the iteration follows the column-major order. | |
| the above code snippet will iterate over elements of ``A`` following the row-major order. |
There was a problem hiding this comment.
Refuse, this will make the col-major ignored. We want to emph that taichi can take care of the raw/col-major switch.
There was a problem hiding this comment.
TBH you could simply say "Same for column-major order."
k-ye
reviewed
May 10, 2020
k-ye
reviewed
May 10, 2020
k-ye
reviewed
May 10, 2020
k-ye
reviewed
May 10, 2020
k-ye
reviewed
May 10, 2020
archibate
commented
May 10, 2020
Co-authored-by: Ye Kuang <k-ye@users.noreply.github.com>
Co-authored-by: Ye Kuang <k-ye@users.noreply.github.com>
Co-authored-by: Ye Kuang <k-ye@users.noreply.github.com>
|
Please do not trigger @taichi-gardener again, I will open a separate PR to run |
yuanming-hu
approved these changes
May 11, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue = #736 #896 #902
[Click here for the format server]