[doc] Minor updates in hello.rst
#963
Conversation
|
@TH3CHARLie thanks for the tips. Although the code samples in |
|
LGTM! The new code samples added in |
| @@ -129,8 +129,8 @@ You can also define Taichi **functions** with ``ti.func``, which can be called a | |||
|
|
|||
| .. note:: | |||
|
|
|||
| **Taichi-scope v.s. Python-scope**: everything decorated with ``ti.kernel`` and ``ti.func`` is in Taichi-scope, which will be compiled by the Taichi compiler. | |||
| Code outside the Taichi-scopes is simply normal Python code. | |||
| **Taichi-scopes v.s. Python-scopes**: everything decorated with ``ti.kernel`` and ``ti.func`` is in Taichi-scope, which will be compiled by the Taichi compiler. | |||
There was a problem hiding this comment.
If you want everything to be scopes, then why not:
| **Taichi-scopes v.s. Python-scopes**: everything decorated with ``ti.kernel`` and ``ti.func`` is in Taichi-scope, which will be compiled by the Taichi compiler. | |
| **Taichi-scopes v.s. Python-scopes**: everything decorated with ``ti.kernel`` and ``ti.func`` is in Taichi-scopes, which will be compiled by the Taichi compiler. |
You may want to run find docs -exec grep -Hw scope {} \; to find out more.
There was a problem hiding this comment.
Let's unify the usage of scope in a separate PR to make this one easier to review :-)
| **Taichi-scope v.s. Python-scope**: everything decorated with ``ti.kernel`` and ``ti.func`` is in Taichi-scope, which will be compiled by the Taichi compiler. | ||
| Code outside the Taichi-scopes is simply normal Python code. | ||
| **Taichi-scopes v.s. Python-scopes**: everything decorated with ``ti.kernel`` and ``ti.func`` is in Taichi-scope, which will be compiled by the Taichi compiler. | ||
| Everything else is in Python-scopes. They are simply Python code. |
There was a problem hiding this comment.
I still feel this a bit unconfortable..
There was a problem hiding this comment.
It doesn't read good to me either, but at least it's grammatically correct. Let's tolerate these places for now (unless there is a solution that is clearly better). Hopefully, someone native in English can help us out in the future.
|
Merging this for v0.6.4. As promised I'll unify the terminologies later: #941 (comment) |
Related issue = #941
(Found these issues while translating the doc to Chinese)
[Click here for the format server]