Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ScreenOrientationService #226

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

splincode
Copy link
Member

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Tests related changes
  • Documentation content changes

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #226 (1e75311) into main (f2ab76c) will increase coverage by 0.08%.
The diff coverage is n/a.

❗ Current head 1e75311 differs from pull request most recent head 8ee228f. Consider uploading reports for the commit 8ee228f to get more accurate results

@@            Coverage Diff             @@
##             main     #226      +/-   ##
==========================================
+ Coverage   88.76%   88.84%   +0.08%     
==========================================
  Files         204      204              
  Lines        1210     1210              
  Branches      130      130              
==========================================
+ Hits         1074     1075       +1     
+ Misses        110      109       -1     
  Partials       26       26              
Flag Coverage Δ
audio 79.92% <ø> (+0.18%) ⬆️
canvas 95.97% <ø> (ø)
common 100.00% <ø> (ø)
geolocation 100.00% <ø> (ø)
intersection-observer 98.00% <ø> (ø)
midi 100.00% <ø> (ø)
mutation-observer 100.00% <ø> (ø)
notification 66.66% <ø> (ø)
payment-request 100.00% <ø> (ø)
permissions 78.78% <ø> (ø)
resize-observer 100.00% <ø> (ø)
speech 100.00% <ø> (ø)
storage 100.00% <ø> (ø)
summary 88.84% <ø> (+0.08%) ⬆️
universal 100.00% <ø> (ø)
view-transition 85.71% <ø> (ø)
workers 98.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@splincode splincode force-pushed the splincode/feat/screen-orientation branch from 3a9598e to e08ec33 Compare October 23, 2023 10:10
@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2023

Visit the preview URL for this PR (updated for commit 8ee228f):

https://ng-web-apis-common--pr226-splincode-feat-scree-eikrbo0x.web.app

(expires Tue, 24 Oct 2023 13:36:10 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: a9d81cd8541a1a45fa12e730c551222bb3d5ceb9

apps/demo/src/app/pages/home/home-page.component.html Outdated Show resolved Hide resolved
libs/screen-orientation/package.json Outdated Show resolved Hide resolved
libs/screen-orientation/package.json Outdated Show resolved Hide resolved
libs/screen-orientation/src/screen.service.ts Outdated Show resolved Hide resolved
@splincode splincode force-pushed the splincode/feat/screen-orientation branch 2 times, most recently from 4f84c1c to a08d452 Compare October 23, 2023 11:20
@splincode splincode force-pushed the splincode/feat/screen-orientation branch 2 times, most recently from 655d219 to 1e75311 Compare October 23, 2023 11:25
@@ -0,0 +1,11 @@
export const SAMPLE_TS = `import {Inject} from '@angular/core';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inject not used

libs/screen-orientation/package.json Outdated Show resolved Hide resolved
libs/screen-orientation/src/screen.service.ts Outdated Show resolved Hide resolved
libs/screen-orientation/src/screen.service.ts Outdated Show resolved Hide resolved
libs/screen-orientation/src/screen.service.ts Outdated Show resolved Hide resolved
@splincode splincode force-pushed the splincode/feat/screen-orientation branch 5 times, most recently from 49045b8 to 5ccbb30 Compare October 23, 2023 13:32
@splincode splincode force-pushed the splincode/feat/screen-orientation branch from 5ccbb30 to 8ee228f Compare October 23, 2023 13:33
@github-actions github-actions bot added the ready to merge ready label Oct 24, 2023
@splincode splincode merged commit 0c2fc5e into main Oct 24, 2023
27 checks passed
@splincode splincode deleted the splincode/feat/screen-orientation branch October 24, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants