Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(permissions): remove deprecated PushPermissionState #261

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

splincode
Copy link
Member

@splincode splincode commented Nov 1, 2023

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Tests related changes
  • Documentation content changes

What is the current behaviour?

Closes #260

PushPermissionState is equal PermissionState

image

Copy link
Contributor

github-actions bot commented Nov 1, 2023

Visit the preview URL for this PR (updated for commit a049eb2):

https://ng-web-apis-common--pr261-splincode-feat-permi-ntnm7uj3.web.app

(expires Thu, 02 Nov 2023 12:20:04 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: a9d81cd8541a1a45fa12e730c551222bb3d5ceb9

@github-actions github-actions bot added the ready to merge ready label Nov 1, 2023
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #261 (a049eb2) into main (37e1e4e) will increase coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #261      +/-   ##
==========================================
+ Coverage   88.76%   88.84%   +0.08%     
==========================================
  Files         204      204              
  Lines        1210     1210              
  Branches      130      130              
==========================================
+ Hits         1074     1075       +1     
+ Misses        110      109       -1     
  Partials       26       26              
Flag Coverage Δ
audio 79.92% <ø> (+0.18%) ⬆️
canvas 95.97% <ø> (ø)
common 100.00% <ø> (ø)
geolocation 100.00% <ø> (ø)
intersection-observer 98.00% <ø> (ø)
midi 100.00% <ø> (ø)
mutation-observer 100.00% <ø> (ø)
notification 66.66% <ø> (ø)
payment-request 100.00% <ø> (ø)
permissions 78.78% <ø> (ø)
resize-observer 100.00% <ø> (ø)
speech 100.00% <ø> (ø)
storage 100.00% <ø> (ø)
summary 88.84% <ø> (+0.08%) ⬆️
universal 100.00% <ø> (ø)
view-transition 85.71% <ø> (ø)
workers 98.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@splincode splincode merged commit ac19010 into main Nov 1, 2023
28 checks passed
@splincode splincode deleted the splincode/feat/permission branch November 1, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞 - TS2552: Cannot find name 'PushPermissionState'. Did you mean 'PermissionState'?
2 participants