Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: deprecate some names #578

Merged
merged 2 commits into from
Jul 18, 2024
Merged

refactor: deprecate some names #578

merged 2 commits into from
Jul 18, 2024

Conversation

splincode
Copy link
Member

No description provided.

Copy link

github-actions bot commented Jul 2, 2024

Visit the preview URL for this PR (updated for commit 3e17988):

https://ng-web-apis-common--pr578-splincode-rename-dsgw5m51.web.app

(expires Fri, 19 Jul 2024 09:07:21 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: a9d81cd8541a1a45fa12e730c551222bb3d5ceb9

@splincode
Copy link
Member Author

@waterplea please, review me

Copy link
Collaborator

@waterplea waterplea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I don't think we should prefix the helpers, just the tokens
  2. We should add use {@link XXX} to deprecation comments, otherwise people will think something is just going away

@splincode
Copy link
Member Author

fixed

Copy link
Collaborator

@waterplea waterplea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we, maybe, drop token descriptions to save bundle size? Or maybe only add them in dev mode like Angular does.

@github-actions github-actions bot added the ready to merge ready label Jul 18, 2024
@splincode
Copy link
Member Author

fixed

@splincode splincode merged commit a001ea7 into main Jul 18, 2024
10 checks passed
@splincode splincode deleted the splincode/rename branch July 18, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants