-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: deprecate some names #578
Conversation
Visit the preview URL for this PR (updated for commit 3e17988): https://ng-web-apis-common--pr578-splincode-rename-dsgw5m51.web.app (expires Fri, 19 Jul 2024 09:07:21 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: a9d81cd8541a1a45fa12e730c551222bb3d5ceb9 |
93034b6
to
880fd65
Compare
@waterplea please, review me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I don't think we should prefix the helpers, just the tokens
- We should add
use {@link XXX}
to deprecation comments, otherwise people will think something is just going away
880fd65
to
9114e3b
Compare
9114e3b
to
380897e
Compare
fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we, maybe, drop token descriptions to save bundle size? Or maybe only add them in dev mode like Angular does.
fixed |
No description provided.