-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide all generated items except for projected types from calling code #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taiki-e
force-pushed
the
underscore-const-names
branch
from
April 18, 2020 21:37
21b6b10
to
add5ca5
Compare
taiki-e
added
S-blocked
Status: Blocked on something else
C-enhancement
Category: A new feature or an improvement for an existing one
labels
Apr 18, 2020
taiki-e
force-pushed
the
underscore-const-names
branch
2 times, most recently
from
April 19, 2020 13:29
9bf87d1
to
c6cd9a2
Compare
taiki-e
changed the title
[WIP] Use underscore_const_names
Hide all items except for projected types from calling code
Apr 19, 2020
Keep support for 1.33, remove |
This comment has been minimized.
This comment has been minimized.
bors bot
added a commit
that referenced
this pull request
Apr 19, 2020
192: Hide all items except for projected types from calling code r=taiki-e a=taiki-e Generate all items except for projected types inside a `const` scope. This makes it impossible for user code to refer to these types. This removes redundant prefix/postfix based on the original type from many generate types. This also remove the `pin_project_show_unpin_struct` flag. Co-authored-by: Taiki Endo <te316e89@gmail.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
taiki-e
force-pushed
the
underscore-const-names
branch
from
April 19, 2020 14:11
c6cd9a2
to
9eba3fe
Compare
taiki-e
changed the title
Hide all items except for projected types from calling code
Hide all generated items except for projected types from calling code
Apr 19, 2020
taiki-e
force-pushed
the
underscore-const-names
branch
from
April 19, 2020 14:14
9eba3fe
to
2577f02
Compare
taiki-e
force-pushed
the
underscore-const-names
branch
from
April 19, 2020 14:17
2577f02
to
fd1924d
Compare
bors r+ |
bors bot
added a commit
that referenced
this pull request
May 7, 2020
211: Hide generated items from --document-private-items r=taiki-e a=taiki-e All of the generated items are private items, but it can be displayed in the document by using the `--document-private-items` flag. Naming will be allowed by #202, so it would probably be preferable to only display it in the document if the user did a naming. cc #124 #202 Related: #192 Co-authored-by: Taiki Endo <te316e89@gmail.com>
taiki-e
removed
the
C-enhancement
Category: A new feature or an improvement for an existing one
label
Jan 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate all items except for projected types inside a
const
scope. This makes it impossible for user code to refer to these types. This removes redundant prefix/postfix based on the original type from many generate types. This also remove thepin_project_show_unpin_struct
flag.