Implement project_replace method.
#194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diggsey
force-pushed
the
project-replace
branch
from
932b151
to
1db85fa
Compare
|
Thanks for the PR! Could you add documentation? |
|
Done 👍 |
Diggsey
force-pushed
the
project-replace
branch
from
353066e
to
760cfc3
Compare
Diggsey
force-pushed
the
project-replace
branch
from
760cfc3
to
62a297e
Compare
taiki-e
reviewed
May 3, 2020
| let proj_ty_generics = self.proj.generics.split_for_impl().1; | ||
| let (impl_generics, ty_generics, where_clause) = self.orig.generics.split_for_impl(); | ||
|
|
||
| let replace_impl = self.replace.map(|replace| { | ||
| quote_spanned! { replace => | ||
| #[allow(unsafe_code)] |
There was a problem hiding this comment.
Suggested change
| #[allow(unsafe_code)] |
#[deny(unsafe_code)] does not deny unsafe code generated by macros (rust-lang/rust#53975)
There was a problem hiding this comment.
Hm, I only added this because it failed the test suite without it, so it doesn't appear like that behaviour is working correctly.
|
@taiki-e I've added the workaround for the compiler bug. I didn't remove the |
|
Ok! I will look into the span issues after merging this PR. |
taiki-e
approved these changes
May 3, 2020
|
bors r+ |
|
Hmm... bors seems to be crashed, I'll merge via the merge button. |
|
Published in 0.4.10. |
bors bot
added a commit
that referenced
this pull request
May 8, 2020
212: Add test for project_replace on panic r=taiki-e a=taiki-e Refs: * rust-lang/rust#47949 * #194 (comment) Co-authored-by: Taiki Endo <te316e89@gmail.com>
taiki-e
added
A-project_replace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented this as an opt-in method, via
#[pin_project(Replace)]because it requiresSelf: Sized, and because I thought it would be safest to disallow using in combination withPinnedDrop(as it would effectively bypass thePinnedDropimplementation).Closes #184