Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Miri on CI #288

Merged
merged 1 commit into from
Oct 4, 2020
Merged

Run Miri on CI #288

merged 1 commit into from
Oct 4, 2020

Conversation

taiki-e
Copy link
Owner

@taiki-e taiki-e commented Oct 4, 2020

The pin guarantees are guarantees of a library, so Miri does not detect
violations of the pin API. However, if the generated unsafe code causes
UB, Miri may be possible to detect it.

Related: rust-lang/miri#823, rust-lang/unsafe-code-guidelines#232 (comment)

The pin guarantees are guarantees of a library, so Miri does not detect
violations of the pin API. However, if the generated unsafe code causes
UB, Miri may be possible to detect it.
@taiki-e
Copy link
Owner Author

taiki-e commented Oct 4, 2020

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 4, 2020

Build succeeded:

@bors bors bot merged commit 46243d2 into master Oct 4, 2020
@bors bors bot deleted the miri branch October 4, 2020 15:30
bors bot added a commit to taiki-e/pin-project-lite that referenced this pull request Jan 11, 2021
49: Run Miri on CI r=taiki-e a=taiki-e

The pin guarantees are guarantees of a library, so Miri does not detect
violations of the pin API. However, if the generated unsafe code causes
UB, Miri may be possible to detect it.

taiki-e/pin-project#288

Co-authored-by: Taiki Endo <te316e89@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant