Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(raiko): install script + makefile CI integration #159

Merged
merged 20 commits into from
May 6, 2024

Conversation

Brechtpd
Copy link
Contributor

@Brechtpd Brechtpd commented May 5, 2024

Uses a makefile to both install all dependencies and build/run/test the provers. Check the README for instructions.

@Brechtpd Brechtpd changed the title feat(raik): makefile CI integration [testing] feat(raiko): makefile CI integration [testing] May 5, 2024
@Brechtpd Brechtpd changed the title feat(raiko): makefile CI integration [testing] feat(raiko): makefile CI integration May 5, 2024
@Brechtpd Brechtpd changed the title feat(raiko): makefile CI integration feat(raiko): install script + makefile CI integration May 5, 2024
Copy link
Contributor

@smtmfft smtmfft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now no need to export env CC & CC_riscv_XXX in makefile?

Oh, it is in Cecilia's pipeline.

scripts/install.sh Outdated Show resolved Hide resolved
cargo risczero install
- name: Build risc0 guest target
run: cargo run --bin risc0-builder
- uses: risc0/risc0/.github/actions/sccache@release-0.19
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does anyone konw why we're sticking with risc0's fork of sccache@release-0.19?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, I just kept it because I'm also not sure what it does.

.github/workflows/ci.yml Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@Brechtpd Brechtpd merged commit a6c1095 into taiko/unstable May 6, 2024
8 checks passed
@Brechtpd Brechtpd deleted the makefile branch May 6, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants