fix: revm bn254 mul issue + cancun support + misc issues #222
Conversation
Brechtpd
changed the title
|
Should we start doing PR in revm main instead of using branches? |
|
The difficulties of having different repos. We should do PRs but not sure what mechanism would be best. Maybe we should do PRs to the main branch on revm side and use specific revs on the raiko side, each revm update also requires a PR in raiko to update the revs which I guess is fine. |
Brechtpd
changed the title
| @@ -56,7 +56,7 @@ | |||
| "l1_contract": null, | |||
| "l2_contract": null, | |||
| "rpc": "https://ethereum-holesky-rpc.publicnode.com", | |||
| "beacon_rpc": "https://api.holesky.blobscan.com", | |||
| "beacon_rpc": "https://fabled-weathered-cherry.ethereum-holesky.quiknode.pro/8f1c66935fa5f9afbda0db43318fe3c9e7b061e1/", | |||
There was a problem hiding this comment.
Should we hide this one into maybe CI secrets to prevent unauthorized accesses from others?
There was a problem hiding this comment.
Maybe we should have a dedicated account for our CI. I'm not paying for this one yet because I just picked the free tier but can buy more capacity if needed. I guess we can see if it's a problem or not, hopefully there's enough free rpcs out there that people won't abuse this one.
| // TODO: we should probably split things up in critical and non-critical parts | ||
| // in the chain spec itself so we don't have to manually all the ones we have to care about. | ||
| if let Some(verified_chain_spec) = | ||
| SupportedChainSpecs::default().get_chain_spec_with_chain_id(input.chain_spec.chain_id) |
There was a problem hiding this comment.
Seems it also relies on fixed image_id checking on-chain (in sgx it's mrenclave, in r0/sp1 it's image_id), as the default value can be override by user.
There was a problem hiding this comment.
Yep! But the config is injected in the code, so it's part of the program itself for both SGX and zkVMs so it will already be part of whatever system is used to ensure the correct code is executed.
Some fixes:
feat/zk-oprevm branch. This is now fixed in thev35_taiko_v2branch: taikoxyz/revm@ec20417c-kzgfeature is enabled, so each block containing a call to this precompile would not work correctly. For cancun support in non-native provers we will also have to make sure thatKzgProof::verify_kzg_proof(https://github.com/taikoxyz/revm/blob/a5c01f345f4362f4d5d8bbddf37e9d8aeb27b0d3/crates/precompile/src/kzg_point_evaluation.rs#L73) works correctly without file IO. I haven't tested it yet, but I think it should be okay because revm also avoids using file io to load in the trusted setup data: https://github.com/taikoxyz/revm/blob/a5c01f345f4362f4d5d8bbddf37e9d8aeb27b0d3/crates/primitives/src/kzg/env_settings.rs#L51. In any case, Taiko doesn't support cancun yet so we don't really need this to work for all provers yet.Issues 1/2 can be triggered in ethereum block
19899808at tx 65, so that block can be used for testing.