Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sp1 patches #349

Closed
wants to merge 6 commits into from
Closed

fix: sp1 patches #349

wants to merge 6 commits into from

Conversation

ctian1
Copy link
Contributor

@ctian1 ctian1 commented Aug 23, 2024

Updates SP1 guest to use latest patched crates. ZkOperation in revm also no longer needs to be used since rust-secp256k1, sha2, and substrate-bn are patched.

I left some miscellaneous changes which I'm happy to remove.

@smtmfft
Copy link
Contributor

smtmfft commented Aug 26, 2024

Hi, @ctian1, I completely rebased your PR to mine #352 and fixed CI issues (to avoid another PR to your repo and merge & waiting for CI), so if there is any more update from you side, can you push directly to mine new PR? Thanks!

@ctian1
Copy link
Contributor Author

ctian1 commented Aug 26, 2024

Sounds good! I'll close this PR then

@ctian1 ctian1 closed this Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants